Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: search logic #4

Merged
merged 4 commits into from
Jul 18, 2024
Merged

feat: search logic #4

merged 4 commits into from
Jul 18, 2024

Conversation

0xtiti
Copy link
Collaborator

@0xtiti 0xtiti commented Jul 17, 2024

closes ZKS-106

Copy link

linear bot commented Jul 17, 2024

ZKS-106 Search function

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
z-kchain-hub-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 6:52pm

@0xtiti 0xtiti marked this pull request as ready for review July 17, 2024 15:49
@0xtiti 0xtiti added hold Do not merge for now and removed hold Do not merge for now labels Jul 17, 2024

// Filter chains based on search term
const filteredChains = ecosystemData?.chains.filter((chain) =>
chain.name.toLowerCase().includes(searchTerm.toLowerCase()),
Copy link
Member

@0xArdy 0xArdy Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the user should be able to search by chainId too, but it can be added in another pr

return (
<section>
<header>
<Title title='Chain list' />
<SearchBar />
<Title title={'Chain list'} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Title title={'Chain list'} />
<Title title="Chain list" />

@0xtiti 0xtiti merged commit f6a50ee into dev Jul 18, 2024
6 checks passed
@0xtiti 0xtiti deleted the feat/search branch July 18, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants